Fix IDIC casts throwing exceptions for is operator checks #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
approved these changes
Jul 22, 2024
dongle-the-gadget
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
is operatorchecks such as inAddRangethrowing exceptions when IDIC indicates it doesn't support that interface. We will still throw if an explicit cast is done. In this scenario IDIC was getting triggered as we had aIReadOnlyListand were trying to check if it implementsICollectionwhich it actually doesn't as it implementsIReadOnlyCollection. So, in that scenario, we should indeed return false rather than throw an exception for the AOT check.Fixes #1671